Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cat of Zero Element Vec (bp #1623) #1625

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 19, 2020

This is an automated backport of pull request #1623 done by Mergify

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot requested a review from a team as a code owner October 19, 2020 16:35
@mergify mergify bot requested review from chick and removed request for a team October 19, 2020 16:35
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Oct 19, 2020
@chick
Copy link
Contributor

chick commented Nov 13, 2020

@seldridge I got assigned to review this. Is this something we want to backport?

* Return 0.U for asUInt of a zero-element Seq

Add a condition to SeqUtils.asUInt to have it return an unspecified
width 0.U when applied to an empty sequence. This enables the ability
to do a Cat of a zero-element sequence.

Signed-off-by: Schuyler Eldridge <[email protected]>

* Test elaboration of Cat on zero-element Seq

Signed-off-by: Schuyler Eldridge <[email protected]>
(cherry picked from commit ac641fb)
@seldridge seldridge force-pushed the mergify/bp/3.2.x/pr-1623 branch from 4b7ef09 to cb5fe76 Compare November 13, 2020 18:12
@seldridge
Copy link
Member

Yes, this would be good to backport. I fixed this up just now---it should be good to go.

@mergify mergify bot merged commit 7203b9a into 3.2.x Nov 13, 2020
@mergify mergify bot deleted the mergify/bp/3.2.x/pr-1623 branch November 13, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants